[PATCH] drm/amdgpu/psp: mark securedisplay TA as optional

[Alex Deucher]

On Wed, Apr 30, 2025 at 4:04 AM Michel Dänzer
<michel.daenzer at mailbox.org> wrote:
>
> On 2025-04-29 15:47, Alex Deucher wrote:
> > This is an optional TA which is only available on
> > certain embedded systems.  Mark it as optional to avoid
> > user confusion.  This mirrors what we already do for
> > other optional TAs.
> >
> > Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/4181
> > Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
> > ---
> >  drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
> > index d54bb13772622..1c843b888475e 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
> > @@ -2214,7 +2214,8 @@ static int psp_securedisplay_initialize(struct psp_context *psp)
> >
> >       if (!psp->securedisplay_context.context.bin_desc.size_bytes ||
> >           !psp->securedisplay_context.context.bin_desc.start_addr) {
> > -             dev_info(psp->adev->dev, "SECUREDISPLAY: securedisplay ta ucode is not available\n");
> > +             dev_info(psp->adev->dev,
> > +                      "SECUREDISPLAY: optional securedisplay ta ucode is not available\n");
> >               return 0;
> >       }
> >
>
> Does it need to be dev_info, or could it be dev_dbg?

The customers that do use these optional TAs generally want
notification of their absence.

Alex

>
>
> --
> Earthling Michel Dänzer       \        GNOME / Xwayland / Mesa developer
> https://redhat.com             \               Libre software enthusiast