[PATCH v2] drm/amd/display: add proper error message for vblank init
Mario Limonciello
mario.limonciello at amd.com
Mon Mar 24 17:24:36 UTC 2025
On 3/21/2025 14:13, Saleemkhan Jamadar wrote:
> v1 - DRM_ERROR to dev_err (Mario)
>
> Update message to identifiy the vblank initialization fail case
>
> Signed-off-by: Saleemkhan Jamadar <saleemkhan.jamadar at amd.com>
> Reviewed-by: Rodrigo Siqueira <siqueira at igalia.com>
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 8dd9bf58eac5..ecc6d48a2585 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -2217,8 +2217,8 @@ static int amdgpu_dm_init(struct amdgpu_device *adev)
> adev_to_drm(adev)->mode_config.cursor_height = adev->dm.dc->caps.max_cursor_size;
>
> if (drm_vblank_init(adev_to_drm(adev), adev->dm.display_indexes_num)) {
> - DRM_ERROR(
> - "amdgpu: failed to initialize sw for display support.\n");
> + dev_err(adev->dev,
> + "amdgpu: failed to initialize vblank sw for display support.\n");
> goto error;
> }
>
FYI - I had suggested drm_err() not dev_err().
More information about the amd-gfx
mailing list