[PATCH v2] drm/amd/display: add proper error message for vblank init

Saleemkhan Jamadar saleemkhan.jamadar at amd.com
Mon Mar 24 18:45:08 UTC 2025


Hi Mario,

Made the suggested change.

Regards,
Saleem

--------------2.34.1
Content-Type: text/plain; charset=UTF-8; format=fixed
Content-Transfer-Encoding: 8bit


v1 - DRM_ERROR to drm_err (Mario)

Update message to identifiy the vblank initialization fail case

Signed-off-by: Saleemkhan Jamadar <saleemkhan.jamadar at amd.com>
Reviewed-by: Rodrigo Siqueira <siqueira at igalia.com>
---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


--------------2.34.1
Content-Type: text/x-patch; name="v2-0001-drm-amd-display-add-proper-error-message-for-vbla.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: inline; filename="v2-0001-drm-amd-display-add-proper-error-message-for-vbla.patch"

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 8dd9bf58eac5..1d3585149b0e 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -2217,8 +2217,8 @@ static int amdgpu_dm_init(struct amdgpu_device *adev)
 	adev_to_drm(adev)->mode_config.cursor_height = adev->dm.dc->caps.max_cursor_size;
 
 	if (drm_vblank_init(adev_to_drm(adev), adev->dm.display_indexes_num)) {
-		DRM_ERROR(
-		"amdgpu: failed to initialize sw for display support.\n");
+		drm_err(adev_to_drm(adev),
+		"amdgpu: failed to initialize vblank sw for display support.\n");
 		goto error;
 	}
 

--------------2.34.1--




More information about the amd-gfx mailing list