New patches to rename "retrace" to "replay"

José Fonseca jose.r.fonseca at gmail.com
Mon Feb 18 09:05:15 PST 2013


On Mon, Feb 11, 2013 at 11:30 PM, Carl Worth <cworth at cworth.org> wrote:
> José Fonseca <jose.r.fonseca at gmail.com> writes:
>> - it must be an user-visible change only, ie, change only the docs,
>> CLI commands, GUI menus, etc
>
> I just pushed a new branch replay-rename with two commits. The first
> commit renames "apitrace retrace" to "apitrace replay" in the CLI. It
> also updates README.markdown to match.
>
>> - backwards compatibility must be retained in CLI commands (i.e,
>> apitrace trace, apitrace retrace must alias to whatever is the new
>> name). But it's fine to hide / not-document these aliases
>
> The second commit adds a simple alias mechanism with
> "retrace"->"replay". Since it's a separate mechanism, none of the
> existing documentation (such as "apitrace --help") is affected.
>
>> - no source file name/symbol renaming, at least not for now. I might
>> eventually do it in an opportune moment, but for now I want to avoid
>> merge conflicts.
>> - no executable renaming (glretrace, d3dretrace) as I have too many
>> private scripts that interface directly with those executables.
>
> It's easy enough to _not_ do things. Consider these not done as
> requested!
>
> (I will say that not renaming the retrace_command identifier does look a
> bit odd. There's now an alias mapping "retrace"->retrace_command which
> would be a little more clear if the identifier were replay_command. But
> I definitely understand the desire to avoid merge conflicts.)

I'm fine with renaming the idenfities/files inside cli/* if you
prefer, as I don't think I have outstanding branches touching those
files.

>> If this is acceptable, and you're willing to carry out the changes,
>> then I''ll merge it.
>
> I also pushed a "replay-rename" for the wiki as well. So look those over
> and feel free to merge, (or let me know if you'd like me to change
> anything).

Sorry, still didn't had time to do this, but will do asap.

> I assume that it's acceptable to rebase feature branches like
> these if I have something to update?

Yep.

> I expected to find the source for the main page of
> http://apitrace.github.com, but apparently that's not in the github wiki
> repository? If I can get access to the source for that page, I'll be
> happy to edit it as well. But maybe that's something that only you can
> edit?

It's https://github.com/apitrace/apitrace.github.com . Feel free to do
a stanging branch like for the wiki. Let me know if there are
problems.

Jose


More information about the apitrace mailing list