[PATCH] retrace: Implement glxCopySubBufferMESA

[José Fonseca]

On Mon, Oct 21, 2013 at 5:54 PM, Alexander Monakov <amonakov at ispras.ru>wrote:

>
>
> On Thu, 17 Oct 2013, Carl Worth wrote:
>
> > This enables replay of a trace captured on ChromeOS.
> >
> > Note: Replaying on EGL is not supported, (will trigger an abort),
> > since, as far as I know, EGL does not provide an equivalent function.
>
> My preference would be to issue a warning and continue replaying; this is
> what
> happens on GLX if the underlying driver does not implement this function.
>
> Other than that, I looked at the patch and it looks good to me.
>
> I'll note that this function, like glFinish and glFlush, is almost, but not
> quite, a candidate for "this call concludes drawing a frame" flag.
>

Yes, I also think that a warning would be more consistent with what we
handle elsewhere. We tend to only abort on context/device initialization,
as that tends to lead to crashes anyway.

Otherwise it also looks good to me.

BTW, if anybody cares, it might be possible to implement this on other
platforms via glRead/WritePixels.

Jose
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/apitrace/attachments/20131022/d00eecb5/attachment.html>