[PATCH] Add glretrace option '--snapshot-format=MD5' that allow write image MD5 to a text format file.
Nigel Stewart
nigels.com at gmail.com
Tue Oct 29 21:46:26 CET 2013
Indeed, this part of the patch looks like it needs revisiting:
diff --git a/retrace/CMakeLists.txt b/retrace/CMakeLists.txt
index 78cceae..3ee7d74 100644
--- a/retrace/CMakeLists.txt
+++ b/retrace/CMakeLists.txt
@@ -103,9 +103,11 @@ if (WIN32 OR APPLE OR X11_FOUND)
if (${CMAKE_SYSTEM_NAME} MATCHES "Linux")
target_link_libraries (glretrace rt)
+ target_link_libraries (glretrace crypto)
if (READPROC_H_FOUND)
target_link_libraries (glretrace ${proc_LIBRARY})
endif ()
+
endif ()
endif ()
@@ -131,9 +133,11 @@ if (ENABLE_EGL AND X11_FOUND AND NOT WIN32 AND NOT APPLE)
if (${CMAKE_SYSTEM_NAME} MATCHES "Linux")
target_link_libraries (eglretrace rt)
+ target_link_libraries (eglretrace crypto)
if (READPROC_H_FOUND)
target_link_libraries (eglretrace ${proc_LIBRARY})
endif ()
+
endif ()
On Tue, Oct 29, 2013 at 10:47 AM, Nigel Stewart <nigels.com at gmail.com> wrote:
> Alex,
>
> Sure, we can all happily agree about having clean and tidy
> patches for consideration.
>
> - Nigel
>
> On Tue, Oct 29, 2013 at 10:25 AM, Alexander Monakov <amonakov at ispras.ru> wrote:
>> Let's hear what more experienced (than myself) maintainers say.
>>
>> Regarding the patch itself, it should avoid adding irrelevant files in
>> thirdparty (such as VS project files), and references to libcrypto should be
>> removed from CMakeLists.txt.
>>
>> Alexander
More information about the apitrace
mailing list