[PATCH] Add glretrace option '--snapshot-format=MD5' that allow write image MD5 to a text format file.

[Meng, Mengmeng]

Hi, sorry, I forgot to remove of crypto. Crypto is redundant now when using .c implementation MD5.


Thanks,
Meng

-----Original Message-----
From: Nigel Stewart [mailto:nigels.com at gmail.com] 
Sent: Wednesday, October 30, 2013 4:46 AM
To: Alexander Monakov
Cc: Meng, Mengmeng; apitrace at lists.freedesktop.org
Subject: Re: [PATCH] Add glretrace option '--snapshot-format=MD5' that allow write image MD5 to a text format file.

Indeed, this part of the patch looks like it needs revisiting:

diff --git a/retrace/CMakeLists.txt b/retrace/CMakeLists.txt index 78cceae..3ee7d74 100644
--- a/retrace/CMakeLists.txt
+++ b/retrace/CMakeLists.txt
@@ -103,9 +103,11 @@ if (WIN32 OR APPLE OR X11_FOUND)

         if (${CMAKE_SYSTEM_NAME} MATCHES "Linux")
             target_link_libraries (glretrace rt)
+            target_link_libraries (glretrace crypto)
             if (READPROC_H_FOUND)
                 target_link_libraries (glretrace ${proc_LIBRARY})
             endif ()
+
         endif ()

     endif ()
@@ -131,9 +133,11 @@ if (ENABLE_EGL AND X11_FOUND AND NOT WIN32 AND NOT APPLE)

     if (${CMAKE_SYSTEM_NAME} MATCHES "Linux")
         target_link_libraries (eglretrace rt)
+        target_link_libraries (eglretrace crypto)
         if (READPROC_H_FOUND)
             target_link_libraries (eglretrace ${proc_LIBRARY})
         endif ()
+
     endif ()


On Tue, Oct 29, 2013 at 10:47 AM, Nigel Stewart <nigels.com at gmail.com> wrote:
> Alex,
>
> Sure, we can all happily agree about having clean and tidy patches for 
> consideration.
>
> - Nigel
>
> On Tue, Oct 29, 2013 at 10:25 AM, Alexander Monakov <amonakov at ispras.ru> wrote:
>> Let's hear what more experienced (than myself) maintainers say.
>>
>> Regarding the patch itself, it should avoid adding irrelevant files 
>> in thirdparty (such as VS project files), and references to libcrypto 
>> should be removed from CMakeLists.txt.
>>
>> Alexander