[Authentication] Small API issues

[Michael Leupold]

These are some small API issues that I'd like to see corrected:
(@Stef: do you rather want text or diffs?)

1. Signals:
- org.freedesktop.Secrets.Collection.CreatedItem => ItemCreated
- org.freedesktop.Secrets.Collection.DeletedItem => ItemDeleted
seems to be a more common way to name a signals (thanks to Kevin Krammer for 
coming up with those)
- org.freedesktop.Secrets.Item.changed => ItemChanged
just "changed" seems to be ambiguous.

2. Methods:
- org.freedesktop.Secrets.Session.CompleteAuthenticate - second argument 
should be OUT
- org.freedesktop.Secrets.Session.Negotiate should get an argument OUT bool 
successful
- how about org.freedesktop.Secrets.Session.SupportedAlgorithms(OUT 
Array<String> algorithms) to faciliate negotiation?

3. Object paths:
- Object paths could be shorter. I'd advocate /<apiname> (eg. /Secrets/...) 
effectively stripping the /org/freedesktop prefix.
- I'd add that item identifiers on the object path MUST be unique identifiers 
that MUST be persistent. That way we could guarantee that synchronization will 
work.
- For the very same purpose I'd also add a unique identifier (UUID) property 
to Collection as renaming them is possible and they thus can't be identified 
using their label. I'd prefer if collections had this uuid as their object 
path as well.

4. Errors:
- add org.freedesktop.Secrets.Error.NoSession for methods calls which require 
a session but have none

Regards,
Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
Url : http://lists.freedesktop.org/archives/authentication/attachments/20090715/ca08daba/attachment.pgp