[Authentication] Small API issues

[Guillaume Martres]

Le mercredi 15 juillet 2009 11:09:50, Michael Leupold a écrit :
> These are some small API issues that I'd like to see corrected:
> (@Stef: do you rather want text or diffs?)
>
> 1. Signals:
> - org.freedesktop.Secrets.Collection.CreatedItem => ItemCreated
> - org.freedesktop.Secrets.Collection.DeletedItem => ItemDeleted
> seems to be a more common way to name a signals (thanks to Kevin Krammer
> for coming up with those)
> - org.freedesktop.Secrets.Item.changed => ItemChanged
> just "changed" seems to be ambiguous.
>
> 2. Methods:
> - org.freedesktop.Secrets.Session.CompleteAuthenticate - second argument
> should be OUT
> - org.freedesktop.Secrets.Session.Negotiate should get an argument OUT bool
> successful
> - how about org.freedesktop.Secrets.Session.SupportedAlgorithms(OUT
> Array<String> algorithms) to faciliate negotiation?
>
> 3. Object paths:
> - Object paths could be shorter. I'd advocate /<apiname> (eg. /Secrets/...)
> effectively stripping the /org/freedesktop prefix.
> - I'd add that item identifiers on the object path MUST be unique
> identifiers that MUST be persistent. That way we could guarantee that
> synchronization will work.
> - For the very same purpose I'd also add a unique identifier (UUID)
> property to Collection as renaming them is possible and they thus can't be
> identified using their label. I'd prefer if collections had this uuid as
> their object path as well.
>
> 4. Errors:
> - add org.freedesktop.Secrets.Error.NoSession for methods calls which
> require a session but have none
>
> Regards,
> Michael
Hi,
Here are some minor API issues I found while reading the spec:
- Service.SearchCollections, Collection.CreateItem and Collection.SearchItems 
have a "fields" argument, but if I'm not mistaken, everywhere else it is 
refered to as the "attributes" of the items.
- Service.SearchCollections could also be renamed to SearchItems since that's 
what it outputs.

-- 
Regards,
Guillaume Martres - https://launchpad.net/~smarter