[Beignet] [PATCH] backend: refine global immediate optimization

Song, Ruiling ruiling.song at intel.com
Thu Jul 20 01:12:34 UTC 2017


Hi Yang Rong,

Please help merge this patch. These lines of code cause build error. And in fact they are not needed.

Hi Yichao,

Sorry for this. In fact these two lines of code should be removed.

Thanks!
Ruiling

> -----Original Message-----
> From: Beignet [mailto:beignet-bounces at lists.freedesktop.org] On Behalf Of
> rander.wang
> Sent: Friday, June 30, 2017 4:29 PM
> To: beignet at freedesktop.org
> Cc: Wang, Rander <rander.wang at intel.com>
> Subject: [Beignet] [PATCH] backend: refine global immediate optimization
> 
> 	for ABS(UD) = UD on Gen, so delete it,
> 	or it make compilation failed on some platform
> 
> Signed-off-by: rander.wang <rander.wang at intel.com>
> ---
>  backend/src/backend/gen_insn_selection_optimize.cpp | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/backend/src/backend/gen_insn_selection_optimize.cpp
> b/backend/src/backend/gen_insn_selection_optimize.cpp
> index eb93a20..08e4ccf 100644
> --- a/backend/src/backend/gen_insn_selection_optimize.cpp
> +++ b/backend/src/backend/gen_insn_selection_optimize.cpp
> @@ -424,14 +424,10 @@ namespace gbe
>              else if(src0.type == GEN_TYPE_UD || src1.type == GEN_TYPE_UD)
>              {
>                unsigned int s0 = src0.value.ud;
> -              if (src0.absolute)
> -                s0 = abs(s0);
>                if (src0.negation)
>                  s0 = -s0;
> 
>                unsigned int s1 = src1.value.ud;
> -              if (src1.absolute)
> -                s1 = abs(s1);
>                if (src1.negation)
>                  s1 = -s1;
> 
> --
> 2.7.4
> 
> _______________________________________________
> Beignet mailing list
> Beignet at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/beignet


More information about the Beignet mailing list