[cairo] custom font options and cairo_t

[Owen Taylor]

On Mon, 2005-07-25 at 14:48 -0400, Carl Worth wrote:
> On Mon, 25 Jul 2005 14:20:56 -0400, Owen Taylor wrote:
> > > Here's a patch that adds cairo_{set,get}_font_options(). It's 
> > > incredibly straightforward. Two notes:
> > > 
> > >  - I've chosen to merge the options set with set_font_options()
> > >    with the options for the surface.
> 
> Yes, that's the whole point of all this, right?

For the point of this exercise, it could also just entirely override
the options from the surface. But merging is better.

> > >  - cairo_get_font_options() gets the set font options, not the
> > >    merged font options. I think this makes more sense: the 
> > >    set font options are what is part of the gstate, the merged
> > >    font options are an artifact.
> 
> Also correct. You get what you set. There's still a way to merge
> manually, (as you demonstrated), and if we returned the merged result
> there wouldn't be any reasonably easy way for the user to unmerge.
> 
> > And here *is* the patch.
> 
> It all looks good to me.

Patch committed.

Regards,
						Owen

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.freedesktop.org/archives/cairo/attachments/20050725/bf7cef92/attachment.pgp