[cairo] [PATCH] OS/2 surface fixes
mozilla at weilbacher.org
Mon Jul 26 01:27:32 PDT 2010
thanks for taking care of the patches.
On 24.07.2010 20:12, Rich Walsh wrote:
> * os2_24bpp.diff - the existing code contains a work-around for older
> video drivers that can't handle 32bpp bitmaps. However, it doesn't
> comply with the OS/2 requirement that the start of each scan line be
> DWORD-aligned. The result is an image that is either skewed or black.
> This fixes the problem using a more efficient data-transfer method.
The fUse24Bpp was not in your previous patch. I think this does not make
sense as a local static variable, as different surfaces could have
different needs regarding 32bit or 24bit drawing. That could happens (in
Firefox), if you surface was for onscreen display, the other for printing).
I think you should make that a flag of the surface structure instead.
Everything looks good to me on a quick glance. :-)
More information about the cairo