[cairo] Lots of endian issues in librsvg

Andreas Falkenhahn andreas at airsoftsoftwair.de
Tue Mar 23 04:02:29 PDT 2010

Hi Dominic,

ok, I've filed a bug entry. Note that I've attached the full versions of the
fixed code because I currently don't have access to any tools necessary
to create a diff patch. Sorry for that.



On 22.03.2010 at 08:09 Dominic Lachowicz wrote:

>Hi Andreas,
>Thanks for looking in to this. Please attach the patches (not the
>whole files - just the differences from the base version) to a bug @
>On Mon, Mar 22, 2010 at 8:07 AM, Andreas Falkenhahn
><andreas at airsoftsoftwair.de> wrote:
>> Hi,
>> I noticed that the rsvg-filter.c part of librsvg has quite a lot of
>endian issues.
>> Many filters expect data to be present in BGRA byte order, but on big
>> systems data will be in ARGB order, of course.
>> I've fixed all endian issues that I came across while playing with
>librsvg on a PPC
>> system. I used librsvg 2.26.0 as the base version. rsvg-cairo-draw.c
>also needs
>> a fix but this is merely a single line.
>> Here are my modified versions so someone can review the changes and
>> include the fixes in the master version:
>> http://www.falkenhahn.com/rsvg-filter.c
>> http://www.falkenhahn.com/rsvg-cairo-draw.c
>> Greets,
>> Andreas
>> --
>> "Remember: It's nice to be important but it's more important to be nice!"
>> --
>> cairo mailing list
>> cairo at cairographics.org
>> http://lists.cairographics.org/mailman/listinfo/cairo
>"I like to pay taxes. With them, I buy civilization." --  Oliver Wendell Holmes

"Remember: It's nice to be important but it's more important to be nice!"

More information about the cairo mailing list