[cairo] [PATCH] Don't mention XFAIL_TESTS anymore
Bryce W. Harrington
b.harrington at samsung.com
Sun Sep 15 21:51:19 PDT 2013
On Sun, Sep 15, 2013 at 08:29:20PM +0100, Chris Wilson wrote:
> On Sun, Sep 15, 2013 at 02:24:12PM +0200, Uli Schlachter wrote:
> > The variable XFAIL_TESTS is not used anymore since commit e90073f7ddc.
> > Instead, we now have special reference images that show the wrong output and the
> > test suite fails a test if it does not match the expected, wrong output.
> It's a reasonable step to bring the text up-to-date. What I feel is
> lacking is information on which tests are known to be problematic and
> why - whether or not it is truly fixable. The issue with .xfail is that
> we lose a central location for such a reference. I guess the README is a
> better place to explain the XFAIL tests, although it would be best to
> put detailed explanations in the test themselves.
I agree; I was surprised to discover this info embedded in the
+1 to moving the documentation to the tests themselves, that's probably
the first place one would look, and it would make it easier to keep the
notes up to date along with the test. If the explanations include some
common tag, then we could search for tests with xfail images but no
explanation, and deal with them.
Also, I was curious if either of you knew if those documented rationales
are still valid with the current codebase?
More information about the cairo