[cairo] [PATCH] Don't mention XFAIL_TESTS anymore

Uli Schlachter psychon at znc.in
Sun Sep 29 04:21:11 PDT 2013

On 16.09.2013 06:51, Bryce W. Harrington wrote:
> On Sun, Sep 15, 2013 at 08:29:20PM +0100, Chris Wilson wrote:
>> On Sun, Sep 15, 2013 at 02:24:12PM +0200, Uli Schlachter wrote:
>>> The variable XFAIL_TESTS is not used anymore since commit e90073f7ddc.
>>> Instead, we now have special reference images that show the wrong output and the
>>> test suite fails a test if it does not match the expected, wrong output.
>> It's a reasonable step to bring the text up-to-date. What I feel is
>> lacking is information on which tests are known to be problematic and
>> why - whether or not it is truly fixable. The issue with .xfail is that
>> we lose a central location for such a reference. I guess the README is a
>> better place to explain the XFAIL tests, although it would be best to
>> put detailed explanations in the test themselves.
> I agree; I was surprised to discover this info embedded in the
> Makefile.am.
> +1 to moving the documentation to the tests themselves, that's probably
> the first place one would look, and it would make it easier to keep the
> notes up to date along with the test.  If the explanations include some
> common tag, then we could search for tests with xfail images but no
> explanation, and deal with them.

Done, see the attached patches. This now seemed big enough to warrant splitting
into two patches.

> Also, I was curious if either of you knew if those documented rationales
> are still valid with the current codebase?

Some of the rationales were obviously wrong (see the commit message). For the
rest: Dunno, cairo's CVS times were long before I ever looked at it.

<alanc> I think someone had a Xprint version of glxgears at one point,
    but benchmarking how many GL pages you can print per second
    was deemed too silly to merge
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Remove-XFAIL_TESTS-from-Makefile.am.patch
Type: text/x-patch
Size: 12492 bytes
Desc: not available
URL: <http://lists.cairographics.org/archives/cairo/attachments/20130929/59c112cd/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-README-Don-t-mention-XFAIL_TESTS-anymore.patch
Type: text/x-patch
Size: 2568 bytes
Desc: not available
URL: <http://lists.cairographics.org/archives/cairo/attachments/20130929/59c112cd/attachment-0001.bin>

More information about the cairo mailing list