[Cogl] [PATCH 2/2] Workaround drisw bug where clipped redraws don't work

Neil Roberts neil at linux.intel.com
Tue May 15 04:27:29 PDT 2012


Robert Bragg <robert at sixbynine.org> writes:

> +      arch = context->gpu.architecture;
> +      if (arch == COGL_GPU_INFO_ARCHITECTURE_LLVMPIPE ||
> +          arch == COGL_GPU_INFO_ARCHITECTURE_SOFTPIPE ||
> +          arch == COGL_GPU_INFO_ARCHITECTURE_SWRAST)
> +	{
> +	  COGL_FLAGS_SET (context->winsys_features,
> +			  COGL_WINSYS_FEATURE_SWAP_REGION, TRUE);
> +	}
> +    }

Is this right? It only enables the swap region feature on a software
renderer. Shouldn't it be the other way around?

Otherwise assuming that gets changed it looks good to me.

Reviewed by: Neil Roberts <neil at linux.intel.com>

- Neil


More information about the Cogl mailing list