[Cogl] [PATCH 2/2] Workaround drisw bug where clipped redraws don't work

[Robert Bragg]

On Tue, May 15, 2012 at 12:27 PM, Neil Roberts <neil at linux.intel.com> wrote:
> Robert Bragg <robert at sixbynine.org> writes:
>
>> +      arch = context->gpu.architecture;
>> +      if (arch == COGL_GPU_INFO_ARCHITECTURE_LLVMPIPE ||
>> +          arch == COGL_GPU_INFO_ARCHITECTURE_SOFTPIPE ||
>> +          arch == COGL_GPU_INFO_ARCHITECTURE_SWRAST)
>> +     {
>> +       COGL_FLAGS_SET (context->winsys_features,
>> +                       COGL_WINSYS_FEATURE_SWAP_REGION, TRUE);
>> +     }
>> +    }
>
> Is this right? It only enables the swap region feature on a software
> renderer. Shouldn't it be the other way around?

Urgh, Fail! :-)

>
> Otherwise assuming that gets changed it looks good to me.
>
> Reviewed by: Neil Roberts <neil at linux.intel.com>
>
> - Neil

thanks,
- Robert