[Cogl] [Resend][Request] Cherry-pick commit 93b7b4c85

[Robert Bragg]

Hi Emil,

We did already cherry pick the msaa patch you refer to to the 1.14
branch, though not the 1.12 branch so far.

Because of a mistake I made when applying the patch, it is split into two parts:
1f84b5c9b41fb053e7d96b93e3558ca03eed2ae0
8a1353a215abf0d51befda30796839e096546f58

I guess you are using the 1.12 branch a.t.m and that's how you came
across this problem?

I would have guessed that people using gnome 3.6 wouldn't tend to
update to a new major version of mesa before updating to gnome 3.8 and
so wouldn't expect this to affect many users of the 1.12 branch.

If we think it is actually quite likely then I don't have any
objection to cherry picking the patches to 1.12, and can look at
spinning a release.

kind regards,
- Robert


On Tue, Apr 23, 2013 at 9:47 AM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> [Resending with slight variations, from a subscribed email]
>
> Hello list
>
> Recently I have noticed that performance of my gnome-shell has
> "degraded". It is related to the fact that recent mesa has exposed
> multisample visuals [1]. Additionally using multisampled visuals may
> lead to crash in gnome-shell
>
> A quick look at the cogl git repo indicates that a fix is present but
> only in the master branch.
>
> Thus can we cherry-pick commit 93b7b4c85 (glx do not use multisample
> visual config for front or pixmap), for the 1.14 and 1.12 branches
>
> A few "Why should we", arguments I believe are benefis
> * Branch 1.14 is used by the latest gnome 3.8
> * Branch 1.12 is used by the gnome 3.6 - the most common gnome 3 out there
> * Improves performance
> * Easy cherry-pick
> * No perceived side effects
>
> Thanks
> Emil
>
> [1] Commit 35840ab18(st/dri: implement MSAA for GLX/DRI2 framebuffers)
>
> _______________________________________________
> Cogl mailing list
> Cogl at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/cogl