[Cogl] Introspection round 2

[Lionel Landwerlin]

Hi Robert,

I just updated my branch on 
https://git.gnome.org/browse/cogl/log/?h=lionel/introspection-next

Inline my responses :

On 25/11/13 16:59, Robert Bragg wrote:
> Thanks this looks good.
>
> One thing we've discussed before that would be good to tweak is that
> every CoglObject instance now has a GTypeInstance member but I think
> this may be redundant. We already have a klass pointer that basically
> serves the same purpose of pointing to a corresponding per-type class
> description. Hopefully we can just cast the klass pointer to a
> GTypeInstance where necessary.

Verified, it works, so I just dropped the GTypeInstance member.

>
> Another thing is that it looks like the cogl_gtype_XYZ_get_type()
> functions have been renamed to cogl_XYZ_get_gtype() instead. It could
> be nice to avoid needing duplicates for these functions but I wonder
> if we might break something if we change these function names? It the
> gobject introspection scanner can't work with the cogl_gtype_
> namespace then maybe we should see if we get away with this rename -
> at least it doesn't look like clutter or gnome-shell refer to the
> current names - and we can add the current names back later if it
> turns out we break something?

I run into problems when trying to get the scanner to parse these 
"cogl_gtype_" functions.
Probably because of the namespace.

For CoglPath I had to add the "cogl2_path_" namespace to the parser to 
get the parser to include these into the introspection data. I might try 
that later.


>
> Is it perhaps possible to avoid needing the COGL_GTYPE_DEFINE_CLASS
> macro since it seems to be used wherever we use
> COGL_OBJECT_DEFINE[_WITH_CODE] and takes the same arguments? Sorry
> that this would reduce you're Ohloh points ;-)

I need to check whether it will make stuff complicated with deprecated 
types.

>
> Would you mind if we don't expose new gtype apis for deprecated Cogl
> apis such as the CoglShader, CoglProgram and CoglVertexBuffer apis?

Done on the new branch.

>
> thanks a lot for looking at this,
> Robert
>
>
> On Fri, Nov 15, 2013 at 3:44 PM, Lionel Landwerlin
> <llandwerlin at gmail.com> wrote:
>> Hi everyone,
>>
>> I just pushed the second of introspection commits to get Cogl usable from
>> Gjs.
>> The branch containing the commits is available here :
>>
>> https://git.gnome.org/browse/cogl/log/?h=lionel/introspection-next
>>
>> This work has been rebase from a previous iteration against the cogl-1.18
>> branch.
>> I managed to used quite a bit of the API, including stuff from
>> CoglGst/CoglPath.
>>
>> Hopefully this work can be landed soon.
>>
>> Cheers,
>>
>> -
>> Lionel
>>
>> _______________________________________________
>> Cogl mailing list
>> Cogl at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/cogl
>>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/cogl/attachments/20131210/b88e28d3/attachment.html>