[Cogl] [PATCH 2/4] Query rectangle tex parameters when creating a foreign texture on GL3

Robert Bragg robert at sixbynine.org
Fri Jan 25 09:09:33 PST 2013


This looks good to land to me:

Reviewed-by: Robert Bragg <robert at linux.intel.com>

thanks,
- Robert

On Thu, Jan 24, 2013 at 12:09 PM, Neil Roberts <neil at linux.intel.com> wrote:
> Previously when creating a foreign rectangle texture it would ignore
> the passed in texture information and query the texture directly when
> using COGL_DRIVER_GL. However this should also work for
> COGL_DRIVER_GL3. This patch changes it to check the private feature
> flags for the texture querying feature instead of directly checking
> the driver value.
> ---
>  cogl/cogl-texture-rectangle.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/cogl/cogl-texture-rectangle.c b/cogl/cogl-texture-rectangle.c
> index 2c3c2a9..f81ecab 100644
> --- a/cogl/cogl-texture-rectangle.c
> +++ b/cogl/cogl-texture-rectangle.c
> @@ -374,7 +374,8 @@ cogl_texture_rectangle_new_from_foreign (CoglContext *ctx,
>    /* Obtain texture parameters */
>
>  #ifdef HAVE_COGL_GL
> -  if (ctx->driver == COGL_DRIVER_GL)
> +  if ((ctx->private_feature_flags &
> +       COGL_PRIVATE_FEATURE_QUERY_TEXTURE_PARAMETERS))
>      {
>        GLint val;
>
> --
> 1.7.11.3.g3c3efa5
>
> _______________________________________________
> Cogl mailing list
> Cogl at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/cogl


More information about the Cogl mailing list