[Cogl] [Patch][Cogl-1.18]: cogl-sdl.h: MSVC Builds: Don't Link to the SDL libraries automatically

Neil Roberts neil at linux.intel.com
Wed Apr 16 03:41:46 PDT 2014


Thanks for the patch. I've pushed it to the master and cogl-1.18
branches.

Regards
- Neil

Fan Chun-wei <fanc999 at yahoo.com.tw> writes:

> Hi,
>
> In a previous patch of mine, #pragma directives were added in cogl-sdl.h 
> to link to the SDL libraries, so that Visual Studio builds using Cogl 
> built with the SDL winsys would build and link properly.  As the current 
> Cogl codebase supports the SDL winsys being built against SDL-1.x and 
> SDL-2.x, this becomes suboptimal as the libraries that need to be linked 
> are by default named differently on SDL-1.x and SDL-2.x.  This patch 
> removes the #pragma directives for Visual Studio builds to link to the 
> SDL libraries, instead people that aren't using SDL directly in their 
> Cogl-using code can define SDL_MAIN_HANDLED in their build flags (i.e. 
> CFLAGS) to avoid an implicit dependency on the SDL/SDL2 libraries.  I 
> will update the Cogl Visual Studio builds files (as well as Clutter's) 
> to reflect on this change as soon this patch is deemed OK for going in.
>
> With blessings, thank you!


More information about the Cogl mailing list