[compiz] patch: libsvg/libsvg-cairo to librsvg
Mirco Müller
macslow at bangang.de
Mon Jul 31 00:02:30 PDT 2006
Am Montag, den 31.07.2006, 00:52 -0400 schrieb Kristian Høgsberg:
> ... a couple of comments on the patch:
>
> - rsvg_init and rsvg_term should not be called per screen, they
> belong in cubeInit and cubeFini.
> - you need to follow the existing structure of readSvgToTexture
> better; call rsvg_handle_free on entry if svgHandle is non NULL to
> prevent leaking when changing slides, call openImageFile to look for
> the svg in the right paths
> - follow the coding style; in a few places you use a full tab instead
> of 4 spaces (maybe your editor is set to 4 space tabs)
I fixed all the stated issues and attached a corrected patch to this
eMail. Please have a quick look at it to cross-check that I didn't miss
anything. Thanks in advance!
Best regards...
Mirco "MacSlow" Müller
--
email - macslow at bangang.de
www - http://macslow.thepimp.net
lowfat - http://macslow.thepimp.net/sponsor-it
-------------- next part --------------
A non-text attachment was scrubbed...
Name: new-svg-to-rsvg.patch
Type: text/x-patch
Size: 6816 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/compiz/attachments/20060731/719ee34f/new-svg-to-rsvg.bin
More information about the compiz
mailing list