[compiz] Re: Latest switcher patches, bugfix.

[Quinn Storm]

To be honest, I'm not sure it does, as I'm not sure what causes the
phantom windows.

However, I am 100% sure the other change (with the activation number)
is necessary, as without it, when the switcher goes to switch to the
next window into the minimized windows, it 100% of the time gets the
-wrong- window.  It works fine with my patch.

Maybe it has to do with starting compiz with windows minimized already?

On Mon, 08 May 2006 21:32:42 +0200
David Reveman <davidr at novell.com> wrote:

> On Sun, 2006-05-07 at 23:14 -0400, Quinn Storm wrote:
> > On Sun, 7 May 2006 22:21:04 -0400
> > Quinn Storm <livinglatexkali at gmail.com> wrote:
> > 
> > > I've attatched a patch to fix a bug in the latest switcher patches
> > > that got put into CVS.  Basically, window order with minimized
> > > windows is undefined, and this fixes it.
> > > 
> > > Also, I notice that in some cases switcher fails to get an icon
> > > for a window.  Perhaps the icon code is forcing a search for a
> > > specific size, rather than 'best-fit'?
> > > 
> > > Also, the patch allows usage of alt+shift+tab (in default
> > > keybindings) to initiate switcher as well.
> > > 
> > > --Quinn
> > 
> > Oops, I just realized, there was one more fix I forgot to do to
> > this, I've attatched it now, it handles the 'phantom windows' that
> > sometimes show up in switcher (I hope).  Also, I couldn't see why
> > you had the test for inShowDesktopMode in there, I never had it and
> > mine worked ok, if you need it, maybe you can figure out how to put
> > it back in?
> 
> I haven't seen any "phantom windows". If you know an application I can
> run or something I can do to reproduce this, I'm interested in that.
> Without test for inShowDesktopMode, you wont see windows that are in
> "show desktop" mode. I don't see how your change fixes anything,
> please explain.
> 
> -David
>