[compiz] Return value from an action function

David Reveman davidr at novell.com
Tue Jan 9 17:16:48 PST 2007


On Sun, 2007-01-07 at 01:36 +0000, Mike Dransfield wrote:
> David Reveman wrote:
> > A non zero return value indicates that the event should be stolen and
> > that no more processing of the event should be done. There might be a
> > few places where initiate functions return FALSE but should instead be
> > returning TRUE. We should fix those cases.
> >
> >   
> 
> Here is a patch for the cases that I am aware of
> There maybe others but not in actions commonly
> initiated by the mouse.

Thanks, I've applied these for now.

> 
> Does the same apply in reverse?  ie.  Should I also
> change the terminate functions to return false to
> swallow the button up event?

Probably, but it's not as important as the input is usually grabbed when
terminate functions are triggered so events will not go to clients even
if they aren't swallowed.

-David



More information about the compiz mailing list