[compiz] window walking interface

[David Reveman]

On Tue, 2007-06-12 at 19:27 +0200, Dennis Kasprzyk wrote:
> Am Dienstag 12 Juni 2007 14:52:53 schrieb Danny Baumann:
> > Hi,
> >
> > > > Thanks for putting these changes in git, it indeed makes more sense
> > > > than the way I did it first.
> > > > I re-made the transparent cube patches to work now with this new
> > > > interface. Tell me what you think about it.
> >
> > I re-did Roi's patches for latest cube plugin changes and coding style.
> >
> > Attached are the following:
> > > 0001-cube-painting-order.txt:
> > >
> > > This is good to go in if you're able to help fix any regressions that
> > > may appear. There's some coding style changes that need to be made
> > > before I can let this go in, though.
> > >
> > > Please replace all C++ comments with C comments, keep declarations at
> > > the beginning of each scope and make sure lines are no longer than 80
> > > columns.
> >
> > This one is replaced by
> > 0001-Improve-cube-paint-order-calculations.patch.
> >
> > > 0002-plugin-events.txt:
> > >
> > > This is not OK. Plugin events should not be used at all now that 3d and
> > > rotate plugins can hook into the cube plugin directly. Just add whatever
> > > hooks that are appropriate to the cube plugin.
> >
> > Replaced by 0002-Added-rotation-state.patch. With that patch, there is a
> > rotation state variable in CubeScreen that is written by the plugin
> > rotating it, rotate in the current case.
> >
> > > 0003-transparent-cube.txt:
> > >
> > > Looks OK. The same coding style changes need to be made here too,
> > > though.
> >
> > Replaced by 0003-Add-cube-transparency.patch (which adds the cube
> > transparency) and
> > 0004-Added-option-to-enable-cube-transparency-only-on-but.patch (option
> > to enable transparency only on 'manual' rotation).
> >
> > Are these patches ok to go in?
> >
> > Regards,
> >
> > Danny
> 
> Hi,
> 
> here are some additional transcube patches.
> 
> 0005:
> Fixes the FrontToBack calculation for inside cube mode.
> 
> 0006:
> Makes the checkFTB function wrapable to allow other plugins like cubereflex to 
> change the result of this function.

Yep, this is what I had mind for proper integration of the 3d plugin
functionality.

> 
> 0007:
> Separates paintTopBottom into individual functions and fixes normals and 
> painting order of the top and bottom caps.
> 
> 0008:
> Adds a wrapable paintInside function to allow other plugins to render 
> something inside of the transparent cube.
> 

All good. Please commit.

Thanks.

-David