[compiz] [PATCH] CompRect more intuitive

Eduardo Gurgel edgurgel at gmail.com
Wed Feb 25 14:12:40 PST 2009


Hi,

Compiz++ uses CompRegion instead of XRectangle, right? This patch tries to
improve CompRect usability

*First*

I was using CompRect, but I've found that the only way to modify a CompRect
is using setGeometry function:

void
CompOutput::setGeometry (int x1, int x2, int y1, int y2);

So I created setX1, setY1, setX2, setY2 functions

*Second*

As you can see above, setGeometry uses: (x1,x2,y1,y2). I'm proposing to
change to setGeometry (x1,y1,x2,y2)

A Rectangle is defined by two points (x1,y1) and (x2,y2). So, setGeometry
will be more intuitive if we use this order.

This patch change all core/plugins and src/

Thanks for attention

P.S.: Sorry for bad english.
-- 
Eduardo Gurgel Pinho
(GELSoL-UFC)

(Gentoo) Linux User #415930
http://edgurgel.wordpress.com
http://alu.dc.ufc.br/~eduardo <http://alu.dc.ufc.br/%7Eeduardo>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.freedesktop.org/archives/compiz/attachments/20090225/839ec0b0/attachment.html 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: comprect.patch
Type: application/octet-stream
Size: 16164 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/compiz/attachments/20090225/839ec0b0/attachment.obj 


More information about the compiz mailing list