[compiz] [PATCH] CompRect more intuitive

[Sam Spilsbury]

On Thu, Feb 26, 2009 at 7:12 AM, Eduardo Gurgel <edgurgel at gmail.com> wrote:
> Hi,
>
> Compiz++ uses CompRegion instead of XRectangle, right? This patch tries to
> improve CompRect usability
>
> First
>
> I was using CompRect, but I've found that the only way to modify a CompRect
> is using setGeometry function:
>
> void
> CompOutput::setGeometry (int x1, int x2, int y1, int y2);
>
> So I created setX1, setY1, setX2, setY2 functions
>

Can you also add int setWidth (), int setHeight () int setX () int
setY () as well?

> Second
>
> As you can see above, setGeometry uses: (x1,x2,y1,y2). I'm proposing to
> change to setGeometry (x1,y1,x2,y2)

Yeah. Do you know which plugins so far use CompRect so we can adapt them?

>
> A Rectangle is defined by two points (x1,y1) and (x2,y2). So, setGeometry
> will be more intuitive if we use this order.
>
> This patch change all core/plugins and src/
>
> Thanks for attention
>
> P.S.: Sorry for bad english.
> --
> Eduardo Gurgel Pinho
> (GELSoL-UFC)
>
> (Gentoo) Linux User #415930
> http://edgurgel.wordpress.com
> http://alu.dc.ufc.br/~eduardo
>
> _______________________________________________
> compiz mailing list
> compiz at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/compiz
>
>



-- 
Sam Spilsbury