code generator in makefiles

Havoc Pennington hp at redhat.com
Sat Feb 19 14:56:06 PST 2005


On Sat, 2005-02-19 at 17:42 -0500, Colin Walters wrote:
> 
> This code looks in large part to me like it was trying to work around an
> Automake without BUILT_SOURCES.  I'm pretty sure the existing code in
> test/glib/Makefile.am is correct, and it's certainly much shorter than
> the code you posted.

Yeah, if that works then you're probably right.

> As for the intermediate file - well, if an error occurs during
> compilation you don't want to have a new half-written target file with a
> timestamp newer than the source, it will cause compilation to fail until
> you delete it manually.  My patch moves the logic for create tempfile
> +rename into the tool itself.

Which would kill the last bit of complexity in test/glib/Makefile.am.
Sounds sensible.

Havoc




More information about the dbus mailing list