[patch] automatically reload config

David Zeuthen david at fubar.dk
Tue Jun 14 18:13:53 PDT 2005


On Tue, 2005-06-14 at 18:03 -0400, Colin Walters wrote:
> About the patch; I'm a bit confused why bus_config_load and takes a
> watch_config_directories argument.  Why not just default it to TRUE
> inside bus_config_parser_new?

Yeah, the thinking was to not use this for tests.

> It also seems a bit evil to start watching the directory in the config
> parser itself; should probably maintain a list of directories and then 
> process_config_every_time does both the drop of watched dirs and the
> invocation of bus_config_watch_directory, retrieving the list via a new
> function, bus_config_parser_get_watched_dirs.

That sounds much smarter. The attached patch should do this.

    David

-------------- next part --------------
A non-text attachment was scrubbed...
Name: dbus-auto-reload-config-2.patch
Type: text/x-patch
Size: 13065 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/dbus/attachments/20050614/04d8480c/dbus-auto-reload-config-2-0001.bin


More information about the dbus mailing list