[patch] small locking fix

Colin Walters walters at verbum.org
Tue Mar 8 17:47:34 PST 2005


> --- dbus/dbus-object-tree.c     17 Feb 2005 21:19:49 -0000      1.15
> +++ dbus/dbus-object-tree.c     9 Mar 2005 00:54:41 -0000
> @@ -445,8 +445,8 @@ _dbus_object_tree_unregister_and_unlock 
>  {
>    int i;
>    DBusObjectSubtree *subtree;
> -  DBusObjectPathUnregisterFunction unregister_function;
> -  void *user_data;
> +  DBusObjectPathUnregisterFunction unregister_function = NULL;
> +  void *user_data = NULL;

A minor point, but I think the D-BUS coding style separates declarations
from initializations.  Havoc has nagged me about it a few times :)

Other than that, this patch looks good to me.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.freedesktop.org/archives/dbus/attachments/20050308/1edeb710/attachment.pgp


More information about the dbus mailing list