[patch] small locking fix

Havoc Pennington hp at redhat.com
Wed Mar 9 08:52:33 PST 2005


On Tue, 2005-03-08 at 20:47 -0500, Colin Walters wrote:
> > --- dbus/dbus-object-tree.c     17 Feb 2005 21:19:49 -0000      1.15
> > +++ dbus/dbus-object-tree.c     9 Mar 2005 00:54:41 -0000
> > @@ -445,8 +445,8 @@ _dbus_object_tree_unregister_and_unlock 
> >  {
> >    int i;
> >    DBusObjectSubtree *subtree;
> > -  DBusObjectPathUnregisterFunction unregister_function;
> > -  void *user_data;
> > +  DBusObjectPathUnregisterFunction unregister_function = NULL;
> > +  void *user_data = NULL;
> 
> A minor point, but I think the D-BUS coding style separates declarations
> from initializations.  Havoc has nagged me about it a few times :)

Yeah, I was going to nag Joe on it then I was feeling un-nitpicky for a
minute ;-)

Havoc




More information about the dbus mailing list