[PATCH] Third and Final (hopefully) (was Re: [PATCH] First pass at finishing the last major feature on the TODO list (RequestName))

John (J5) Palmieri johnp at redhat.com
Tue Nov 22 08:35:43 PST 2005


On Mon, 2005-11-21 at 21:24 -0500, Havoc Pennington wrote:
> Hi,
> 
> I looked at this patch in a less-thorough way than I wanted, but did
> have a quick read finally. The only question I have is that in
> bus_service_add_owner(), it looks like it's possible to replace 
> the current head of the queue; but if you replace the existing owner
> with a new owner here, is the "name lost" signal sent to the old owner?
> Is it possible to even run this code or is swap_owner() used
> instead? It's a little hard to see what's going on without applying the
> patch and looking at the finished code.

It uses the same mechanisms as before, namely place the new owner after
the current owner and then swap.  The tests confirm that signals are
received correctly.

-- 
John (J5) Palmieri <johnp at redhat.com>



More information about the dbus mailing list