[PATCH] Third and Final (hopefully)

[Havoc Pennington]

On Tue, 2005-10-25 at 20:16 -0400, John (J5) Palmieri wrote:
> Third pass.  This time I added signal checking to the tests and they
> look like they are coming in correctly.  It is a bit ugly since I
> decided it was better if I checked the message queues directly instead
> of having to deal with dispatch functions and trying to sanity check
> async.  Everything passes with flying colors and I was even able to use
> the current expected queue data to determine what signals to look for.
> Is it ok to commit?
> 
> After I get this in (with the huge ChangeLog) I am also going to commit
> all the other ABI breaking changes that are currently pending.
> 

Give me a little time to look at this one, I think it's worth reviewing
since it's so big. I'd appreciate it if anyone else wants to review it
also, my patch-review-fu really isn't that good (Owen for example always
finds 10x the bugs on review that I do). Maybe Ross, Alex, Mark, ? or
someone could look over the code or at least the proposed new behavior
in the spec patch?

One thing that may be worthwhile is to go through the spec for this and
be sure each "it must do such-and-such in such-and-such case" has a
corresponding test... just kind of map from tests to sentences in the
spec and see if any important/tricky sentences are missing.

BTW, there's no real proof that we have the new spec right, so it would
be good to get some real-world sense of that maybe during the march to
1.0. After being pre-1.0 for so long it probably makes sense to do a
series of 0.9x releases with a feature freeze and "bugfixes only" in
effect but API/ABI changes allowed if significant issues are discovered,
no? Do you guys have a plan already? ;-)

Something we should consider for 1.0 also is getting the basic dbus
tutorial written out, and cleaning up the doxygen warnings about any
missing or broken reference docs, maybe glancing over all the doxygen
output for silliness. The most important docs task is probably just a
"hello world" example using each of the working bindings showing the
right way to talk to other apps in a desktop session.

Should also look over:
http://dbus.freedesktop.org/doc/api/html/todo.html
(well, that says it was generated Aug 2, so a newer version)

Anything in there look important?

Havoc