[PATCH] ListServices

John (J5) Palmieri johnp at redhat.com
Thu Jul 13 18:19:23 PDT 2006


Committed. Thanks.

On Thu, 2006-07-13 at 10:56 +0200, Carlos Garcia Campos wrote:
> El mié, 12-07-2006 a las 21:42 -0400, Havoc Pennington escribió:
> > Hi,
> > 
> > Carlos Garcia Campos wrote:
> > > Havoc, 
> > > 
> > > I've added test coverage to the new bus method (ListServices) and I've
> > > updated the documentation (dbus-specification). 
> > > 
> > > Here is the new patch:
> > > 
> > > http://carlosgc.linups.org/files/dbus-list-services3.diff
> > > 
> > > is this what you meant with test coverage?
> > > 
> > 
> > Yes! fantastic, thank you very much.
> > 
> > The patch looks great. I just had one more thought; what if we name it 
> > ListActivatableNames instead of ListServices. That will have a couple of 
> > advantages:
> >   - the word "service" still tends to cause confusion, have been trying 
> > to say "bus name" or "connection/process" instead
> >   - it makes it clear that it lists activatable rather than activated
> >   - it parallels the ListNames method
> > 
> > If that makes sense to you I think it's fine to commit with this change.
> 
> Yeah, I agree. Here is the new patch:
> 
> http://gsyc.escet.urjc.es/~carlosgc/files/dbus-list-activatable-names.diff
> 
> > Havoc
> > 
> _______________________________________________
> dbus mailing list
> dbus at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dbus
-- 
John (J5) Palmieri <johnp at redhat.com>



More information about the dbus mailing list