[patch][python] Improve dbus.Interface, simplify dbus.ProxyObject __getattr__

John (J5) Palmieri johnp at redhat.com
Fri Apr 27 10:01:28 PDT 2007


On Fri, 2007-04-27 at 13:15 +0100, Simon McVittie wrote:
> See attached.
> 
> dbus._dbus.Interface really belongs in dbus.proxies (and I'm trying to
> tidy up dbus._dbus) so I've moved it there. It's also still available as
> dbus.Interface.
> 
> I can't see why the __getattr__ in ProxyObject and Interface needs to be
> so complicated - and if you want methods bound to a particular
> interface, there are many other ways to get them - so I've simplified
> things.
> 
> I've also removed the special case for __call__ since Rob McQueen and I
> are pretty sure it makes no sense - it returns an unbound method which,
> when called, returns an anonymous object of no use to anyone.
> 
> 	Simon

Looks good.  I think there was confusion at one point where parameters
were passes.  As they are passed to the returned callable object and not
the __getattr__ the extra arguments in __getaddr__ were useless.
Thanks.
 
-- 
John (J5) Palmieri <johnp at redhat.com>



More information about the dbus mailing list