user auth patches

Havoc Pennington hp at
Fri Jun 15 13:19:11 PDT 2007


Ralf Habacker wrote:
> Unfortunally your patch breaks compiling of main.c because you have 
> removed the part
> #ifdef DBUS_WIN
> #include <dbus/dbus-sysdeps-win.h>
> #endif

I took this out to break the code you mention, because any code relying 
on the above is definitely wrong. The purpose of the sysdeps-unix.h and 
sysdeps-win.h headers is that they are only included in 
platform-specific files. main.c is not a platform-specific file.

Please study the pattern in the attached patch. The approach is:
  1) add function in dbus-sysdeps.h which does the logical 
cross-platform operation
  2) adapt cross-platform code to use said function
  3) implement said function in sysdeps-unix.c or sysdeps-win.c
  4) submit patch for review and commit afterward
  5) wait for the maintainer of the other port to implement it for the 
other platform

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: dbus-conf.patch

More information about the dbus mailing list