user auth patches

Ralf Habacker ralf.habacker at
Fri Jun 15 14:10:37 PDT 2007

Havoc Pennington schrieb:
> Hi,
> Ralf Habacker wrote:
>> Unfortunally your patch breaks compiling of main.c because you have 
>> removed the part
>> #ifdef DBUS_WIN
>> #include <dbus/dbus-sysdeps-win.h>
>> #endif
> I took this out to break the code you mention, because any code 
> relying on the above is definitely wrong. The purpose of the 
> sysdeps-unix.h and sysdeps-win.h headers is that they are only 
> included in platform-specific files. main.c is not a platform-specific 
> file.
> Please study the pattern in the attached patch. The approach is:
>  1) add function in dbus-sysdeps.h which does the logical 
> cross-platform operation
>  2) adapt cross-platform code to use said function
>  3) implement said function in sysdeps-unix.c or sysdeps-win.c
we were already here.
>  4) submit patch for review and commit afterward
this was discussed already on the mailing list.

>  5) wait for the maintainer of the other port to implement it for the 
> other platform
now we are here

Thanks for your effort.


> Havoc

More information about the dbus mailing list