winDBus authentication stage

Ralf Habacker ralf.habacker at freenet.de
Wed Mar 14 10:43:27 PDT 2007


Havoc Pennington schrieb:
> Ralf Habacker wrote:
>> No problem, there is a file in the code which is highly platform and
>> compiler specific, I mean config.h.
>> So I'm going to provide a patch which #define a DBUS_PATH_SEPARATOR in
>> config.h.cmake and move split_paths_and_append() into dbus-sysdeps.c
>>
>> but who will do so for the unix automake build system ?
>
> If we aren't going to detect this in configure, there isn't really a
> reason to put it in config.h, I guess.Just do:
>  #ifdef DBUS_WIN
>  #define _DBUS_PATH_SEPARATOR
>  #else
>  #define _DBUS_PATH_SEPARATOR
>  #endif
>
> in dbus-sysdeps.h
>
> It's an ifdef but there's an exception to every rule... this is the
> cleanest approach I can think of and isn't papering over a root code
> organization problem.
>
> Note the _ in front of the macro, since it's internal.
okay
>
> I think there may also be problems with the "C:" and other path name
> rules, no? I'm not sure this will work out quite as cleanly as one
> might hope but we'll see.
yes, we will see

I've updated the patch. Please review.

Ralf



More information about the dbus mailing list