Havoc Pennington hp at redhat.com
Wed Oct 10 09:23:42 PDT 2007

Simon McVittie wrote:
> Here are some patches to implement and use DBUS_ERROR_INIT.

The DBUS_ERROR_INIT implementation looks good, but the dbus coding style 
(usually) looks like:

  int foo;
  int bar;

  foo = 0;
  bar = 0;


  int foo = 0;
  int bar = 0;

So the patch to use DBUS_ERROR_INIT doesn't match the surrounding code. 
Of course, error = DBUS_ERROR_INIT after declaration is not allowed. 
Maybe just leaving the dbus_error_init() in dbus itself is fine.


More information about the dbus mailing list