[PATCH] Re: DBUS_ERROR_INIT
simon.mcvittie at collabora.co.uk
Thu Oct 11 02:53:40 PDT 2007
-----BEGIN PGP SIGNED MESSAGE-----
On Wed, 10 Oct 2007 at 12:23:42 -0400, Havoc Pennington wrote:
> Simon McVittie wrote:
> > Here are some patches to implement and use DBUS_ERROR_INIT.
> The DBUS_ERROR_INIT implementation looks good, but the dbus coding style
> (usually) looks like:
> int foo;
> int bar;
> foo = 0;
> bar = 0;
Well, if you're sufficiently attached to this coding style to not care
about the unnecessary function calls, I'll omit the last patch...
(for what it's worth, in Telepathy we use initializers wherever needed,
including "simple" function calls and macros, but don't generally allow
function calls with side-effects to be used as an initializer).
I've committed the first two patches, with a note in ChangeLog about why
we're not actually using DBUS_ERROR_INIT in dbus core.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: OpenPGP key: http://www.pseudorandom.co.uk/2003/contact/ or pgp.net
-----END PGP SIGNATURE-----
More information about the dbus