[PATCH 2/2] configure.in: not all gccs support -Wno-pointer-sign

Thiago Macieira thiago at kde.org
Fri Apr 17 13:44:13 PDT 2009


Marc Mutz wrote:
>---
> configure.in |    5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
>diff --git a/configure.in b/configure.in
>index 90f9f41..ecb0bc8 100644
>--- a/configure.in
>+++ b/configure.in
>@@ -284,7 +284,10 @@ if test "x$GCC" = "xyes"; then
>   esac
>   case " $CFLAGS " in
>   *[\ \	]-Wno-pointer-sign[\ \	]*) ;;
>-  *) CFLAGS="$CFLAGS -Wno-pointer-sign" ;;
>+  *) if cc_supports_flag -Wno-pointer-sign; then
>+        CFLAGS="$CFLAGS -Wno-pointer-sign"
>+     fi
>+     ;;
>   esac
>
>   # http://bugs.freedesktop.org/show_bug.cgi?id=19195

This patch makes sense, thanks for doing it.

Should we do it also for the other flags that we use?

-- 
  Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
Url : http://lists.freedesktop.org/archives/dbus/attachments/20090417/9df1c0a0/attachment.pgp 


More information about the dbus mailing list