[PATCH 2/2] configure.in: not all gccs support -Wno-pointer-sign

[Marc Mutz]

On Friday 17 April 2009, Thiago Macieira wrote:
> Marc Mutz wrote:
> >---
> > configure.in |    5 ++++-
> > 1 files changed, 4 insertions(+), 1 deletions(-)
> >
> >diff --git a/configure.in b/configure.in
> >index 90f9f41..ecb0bc8 100644
> >--- a/configure.in
> >+++ b/configure.in
> >@@ -284,7 +284,10 @@ if test "x$GCC" = "xyes"; then
> >   esac
> >   case " $CFLAGS " in
> >   *[\ \	]-Wno-pointer-sign[\ \	]*) ;;
> >-  *) CFLAGS="$CFLAGS -Wno-pointer-sign" ;;
> >+  *) if cc_supports_flag -Wno-pointer-sign; then
> >+        CFLAGS="$CFLAGS -Wno-pointer-sign"
> >+     fi
> >+     ;;
> >   esac
> >
> >   # http://bugs.freedesktop.org/show_bug.cgi?id=19195
>
> This patch makes sense, thanks for doing it.
>
> Should we do it also for the other flags that we use?

It probably makes sense to have a function that wraps these repeated checks, 
then again, one shouldn't add unnecessary checks to configure, to not let it 
run for too long.

Thanks,
Marc

-- 
Marc Mutz -- marc at klaralvdalens-datakonsult.se, mutz at kde.org
Klarälvdalens Datakonsult AB, Platform-independent software solutions