marc at kdab.net
Wed Apr 22 09:22:45 PDT 2009
On Wednesday April 22 2009, Marc Mutz wrote:
> On Tuesday April 21 2009, Colin Walters wrote:
> > See also Tor's outstanding patch:
> > http://bugs.freedesktop.org/show_bug.cgi?id=16788
> > Is any of that work in your tree?
> Not yet. But thanks for pointing that out to us, we will make sure to take
> that patch into account.
I've started to break down Tor's huge patch into pieces, in the patch-16788
branch of repo.or.cz/dbus4win.git. HEAD of that beast is the patch from
BR#16788, but _resorted_ so see the actual diffs in the *-win.c files.
I cannot stress enough that this is a very valueable contribution, but
unfortunately unusable until it's all disentangled. One thing left is to keep
out whitespace changes until very last, otherwise cherry-picking these
commits will immediately reject. I know this is boring and hard work (I spent
the better part of today on it :/), but there's a snowball's chance in hell
for getting a 220K patch upstream.
Tor, I would really appreciate if you could continue, please. At least write
some kind of changelog so I can see the trees in the remaining forest (German
saying). Esp the error handling changes are all over the place. Knowing in
which order you did them originally would go a long way to make things
Marc Mutz <marc at kdab.com> | Senior Software Engineer
KDAB (Deutschland) GmbH & Co.KG, a KDAB Group Company
www.kdab.com || Germany +49-30-521325470 || Sweden (HQ) +46-563-540090
KDAB - Qt Experts - Platform-Independent Software Solutions
More information about the dbus