draining the Maemo/Meego patch queue

[Thiago Macieira]

Em Terça-feira 16 Março 2010, às 19:04:03, Colin Walters escreveu:
> * 02-allow-all-in-session.patch
> Maemo specific - however, I'd totally take a patch which added
> bus/maemo-session.conf.

I wouldn't. Maemo-specific patches should be left in Maemo's tree, including 
its changes to the config file.

> * 09-remove-max-match-limit.patch
> I think this one could also be done in bus/maemo-session.conf

Agreed. But given my comment above, this means the patch would stay in Maemo's 
tree.

> * 17-do-not-inherit-oom-adj.patch
> No upstream bug.  But a reasonable patch, would like to see it upstream.

Agreed.

> * 35-fixed-socket-dir.patch
> Maemo specific, could go in maemo-session.conf again.

See above.

> * 36-bug-896-ignore-epipe-on-writes.patch
> This was committed earlier as 87ddff6b

D-Bus 1.3 also uses MSG_NOSIGNAL, but that's Linux-specific.

> * 40-prevent-autolaunch.patch
> No upstream bug.  Not clear why this patch exists?

No idea either, though on Maemo I don't see how autolaunch works or how the 
bus is found anyway. My tests indicate I always connect to the bus, even when 
connecting as a separate user, via ssh.

> * 00_dbus-quiesce-startup-errors.patch
> No upstream bug.  I'm a bit on the fence on this one.  What we should
> actually probably do is try again after a short period of time.  I
> admit it's lame we just fail right now.

Hmm... if we read the file while it's in-flight, shouldn't we get a new 
notification from the filesystem when it's changed again? Won't we read the file 
again at that time?

If that's the case, I'd say just quickly skip any malformed files and don't 
cause any ill-effects -- unless the bus is starting, in which case it should 
complain and refuse to start.

-- 
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
  Senior Product Manager - Nokia, Qt Development Frameworks
      PGP/GPG: 0x6EF45358; fingerprint:
      E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/dbus/attachments/20100316/131548ce/attachment-0001.pgp>