dbus remaining windows port issues

Marcus Brinkmann marcus.brinkmann at ruhr-uni-bochum.de
Mon May 3 03:50:25 PDT 2010

On 05/03/2010 10:18 AM, Fridrich Strba wrote:
> It is arguable whether one should include config.h in those two private
> headers. It is eventually possible to make the same include block:
> #ifdef HAVE_CONFIG_H
> #include <config.h>
> #endif
> #include <inttypes.h>
> #endif
> in every *.c file before including dbus-pipe.h or dbus-hash.h.

Every .c file that is built for the host platform *must* include config.h
before every other header file, including system header files!  So the first
three lines above are redundant in *any* header file, and may hide bugs where
.c files do not include config.h although they should, or header files
intended for the host are used in build-system only tools etc.

The last three lines should be in the header file that needs inttypes.h, of


More information about the dbus mailing list