[Patch] socket descriptor leak on Windows

Romain Pokrzywka romain at kdab.com
Tue May 4 07:11:02 PDT 2010


Hi,

Here's a small patch fixing a socket descriptor unneeded creation and leak on windows. This looks like forgotten 
leftovers of an older version of the code before ipv6 support was added, or possibly a bad merge during the merge of 
dbus4win back into trunk.
Anyway that socket is unneeded and unused, and I made sure getaddrinfo doesn't need it, so it can safely be removed.

I've noticed there's a bugzilla entry for that issue too (https://bugs.freedesktop.org/show_bug.cgi?id=19416), please 
close it after committing the patch.

Patch tested with msvc on win32 and wince. Unfortunately it doesn't solve the random lockup from bus-test as I prayed it 
would...

-- 
Romain Pokrzywka | romain at kdab.com | Certified Qt Software Engineer & Trainer
Klarälvdalens Datakonsult AB, a KDAB Group company
Tel. Sweden (HQ) +46-563-540090, USA +1-866-777-KDAB(5322)
KDAB - Qt Experts - Platform-independent software solutions
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-remove-unused-and-leaked-socket.patch
Type: text/x-patch
Size: 1339 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/dbus/attachments/20100504/0eaa38bb/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/dbus/attachments/20100504/0eaa38bb/attachment.pgp>


More information about the dbus mailing list