Changing dbus/dbus-glib review procedure

Colin Walters walters at
Tue May 17 13:24:31 PDT 2011

Hi Simon,

On Tue, May 17, 2011 at 10:18 AM, Simon McVittie
<simon.mcvittie at> wrote:
> * Add David Zeuthen (GDBus maintainer) to the list of qualified reviewers.
>  This hopefully shouldn't be controversial; Will Thompson has said he's in
>  favour of this addition too.

Seems obvious to me.

> * Relax the review requirement for branches written by someone who's also a
>  reviewer: the D-Bus reviewers listed in HACKING may commit branches they
>  wrote themselves, as long as:

I'd also add the qualifications:

- Has tests
- Solves a known problem (it's not just code churn for the sake of code churn)

Anyways, yes there's really no point in having your epoll() changes
and the like sit outside the tree for too long.

More information about the dbus mailing list