[PATCH] Do not build test binaries at 'make all' stage

Yang Chengwei chengwei.yang at intel.com
Tue Jul 9 07:27:16 PDT 2013

On Thu, May 30, 2013 at 02:23:45PM +0100, Simon McVittie wrote:
> On 30/05/13 14:02, Chengwei Yang wrote:
> > Use check_ instead of noinst_ to avoid build test binaries at 'make all'
> > stage, and these binaries then built at 'make check' stage.
> > 
> > Since not every one will 'make check', so it will save several seconds
> > for them.
> This is done deliberately, to stop the test binaries ceasing to compile
> at all (although ideally, all developers would run "make check" anyway).
> Did you see this comment?
> >  ## we use noinst_PROGRAMS not check_PROGRAMS for TESTS so that we
> >  ## build even when not doing "make check"
> We have plenty of CPU time and not enough maintainer time; I would

After working with dbus these days, I still prefer not build test in
'make all' stage but in 'make check' stage.

Always build test binaries will not leading the developer to run 'make
check' but do slow down the development cycle.

I always want to do 'make' to ensure the change compile fine, and then
run 'make check' to ensure the change doesn't break any test.

As common, one may need several times of change to make it pass compile,
so it may wastes a lot of time to build *not used* test binaries.


> prefer to limit the number of conditional things.
>     S
> _______________________________________________
> dbus mailing list
> dbus at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dbus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/dbus/attachments/20130709/947ec006/attachment.pgp>

More information about the dbus mailing list