[PATCH] enable build support without systemd compatibility libraries
Simon McVittie
simon.mcvittie at collabora.co.uk
Tue Sep 2 03:10:17 PDT 2014
On 02/09/14 08:02, Umut Tezduyar Lindskog wrote:
> systemd 209 merged all the libraries to libsystemd. Old
> libraries can still be enabled with --enable-compat-libs
> switch in systemd but this increases the binary size.
Please send patches to Bugzilla so they don't get lost.
> PKG_CHECK_MODULES(SYSTEMD,
> [libsystemd-login >= 32, libsystemd-daemon >= 32, libsystemd-journal >= 32],
> have_systemd=yes,
> - have_systemd=no)
> + PKG_CHECK_MODULES(SYSTEMD,
> + [libsystemd >= 209],
> + have_systemd=yes,
> + have_systemd=no))
This looks reasonable, but is "underquoted" (the rule of thumb should be
one pair of [] per pair of ()).
Shouldn't the check be the other way round, so we check for libsystemd
if available, and fall back to libsystemd-* if not?
If you want to reduce binary size in a packaged distribution, it would
seem reasonable to package the compat *.pc files in a -dev/-devel
package, but not package the compat libraries: that's API-compatible
(but not ABI-compatible) with systemd < 209, and would allow dbus to be
compiled without changes.
S
More information about the dbus
mailing list