[PATCH] enable build support without systemd compatibility libraries

[Umut Tezduyar Lindskog]

Hi Simon,

On Tue, Sep 2, 2014 at 12:10 PM, Simon McVittie
<simon.mcvittie at collabora.co.uk> wrote:
> On 02/09/14 08:02, Umut Tezduyar Lindskog wrote:
>> systemd 209 merged all the libraries to libsystemd. Old
>> libraries can still be enabled with --enable-compat-libs
>> switch in systemd but this increases the binary size.
>
> Please send patches to Bugzilla so they don't get lost.

I will do that.

>
>>      PKG_CHECK_MODULES(SYSTEMD,
>>          [libsystemd-login >= 32, libsystemd-daemon >= 32, libsystemd-journal >= 32],
>>          have_systemd=yes,
>> -        have_systemd=no)
>> +        PKG_CHECK_MODULES(SYSTEMD,
>> +            [libsystemd >= 209],
>> +            have_systemd=yes,
>> +            have_systemd=no))
>
> This looks reasonable, but is "underquoted" (the rule of thumb should be
> one pair of [] per pair of ()).

I didn't understand what you are referring. Could you please explain
it? I am looking at the parenthesises and don't see anything missing.

>
> Shouldn't the check be the other way round, so we check for libsystemd
> if available, and fall back to libsystemd-* if not?

I guess it makes more sense to have the libsystemd check first since
libsystemd is the future.

>
> If you want to reduce binary size in a packaged distribution, it would
> seem reasonable to package the compat *.pc files in a -dev/-devel
> package, but not package the compat libraries: that's API-compatible
> (but not ABI-compatible) with systemd < 209, and would allow dbus to be
> compiled without changes.

We have our own distro for our embedded product. We don't have
dev/devel kind of things. But thanks anyways.

Umut

>
>     S
>
> _______________________________________________
> dbus mailing list
> dbus at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dbus